From 596aae8b67796ac093b668b0b3e301af8ff72d8f Mon Sep 17 00:00:00 2001
From: Tim McCormack <tmccormack@edx.org>
Date: Wed, 28 Feb 2024 19:09:59 +0000
Subject: [PATCH] feat: Add Atlas pull_translations after Makefile fixes

This reverts commit 70eb14260dd808e50d0575cea773038e4f01cee8
and makes the following changes:

- No need to install atlas directly -- the openedx-atlas package
  actually has what we need already.
- After https://github.com/openedx/edx-platform/pull/34306 we
  shouldn't encounter npm issues.
---
 playbooks/roles/edxapp/tasks/deploy.yml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/playbooks/roles/edxapp/tasks/deploy.yml b/playbooks/roles/edxapp/tasks/deploy.yml
index 9c30c62103f..c58c63cd6f4 100644
--- a/playbooks/roles/edxapp/tasks/deploy.yml
+++ b/playbooks/roles/edxapp/tasks/deploy.yml
@@ -357,6 +357,21 @@
   failed_when: "'17017' not in sandbox_test3.stdout"
   when: EDXAPP_SANDBOX_ENFORCE
 
+- name: "Pull translations using Atlas (after Python dependencies and Node installed)"
+  shell: |
+    set -eu -o pipefail
+    source {{ edxapp_venv_dir }}/bin/activate
+    # Use production-like environment and minimal config to avoid needing dev dependencies or full config.
+    PATH="./bin/:$PATH" DJANGO_SETTINGS_MODULE=lms.envs.production \
+      LMS_CFG=lms/envs/minimal.yml STUDIO_CFG=lms/envs/minimal.yml \
+      OPENEDX_ATLAS_PULL=true make pull_translations
+  args:
+    executable: /usr/bin/bash
+    chdir: "{{ edxapp_code_dir }}"
+  become_user: "{{ edxapp_user }}"
+  tags:
+    - install
+
 - name: compiling all py files in the edx-platform repo
   shell: "{{ edxapp_venv_bin }}/python -m compileall -q -x '.git/.*|node_modules/.*' {{ edxapp_code_dir }}"
   become_user: "{{ edxapp_user }}"