-
Notifications
You must be signed in to change notification settings - Fork 966
fix: retirement pipeline pip version #7047
fix: retirement pipeline pip version #7047
Conversation
With current version of the pip (19.0.3) it is impossible to install the cryptography package with version higher than 39.X.X (starting from the palm release it is 40+, source: https://github.com/openedx/tubular/blob/open-release/palm.3/requirements/base.txt#L47) The issue could be resolved by either installing the rustc to build the package or upgrading the pip version to use the prebuild wheel which is the recommendation from the cryptography setup guide: https://cryptography.io/en/latest/installation/#building-cryptography-on-linux In this PR I increase the pip version using the version pinned in the tubular requirements: https://github.com/openedx/tubular/blob/master/requirements/pip.txt#L11 The pip version installation described here https://github.com/openedx/configuration/blob/master/playbooks/roles/user_retirement_pipeline/tasks/main.yml#L34
Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @edx-secure @adzuci! Would someone be able to please review / merge this for us once the master is merged? Thanks! |
Hi @dyudyunov , could you update this PR with the changes from #7046 when you get a chance? They're cutting quince.2 tonight, so it'd be great if we could get this in before then. |
Hi! Done! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this using the procedure described here
- I checked the code against the original fix: retirement pipeline pip version #7046
Hi @dyudyunov My apologies, I didn't see your changes in time to approve them before quince.2 got cut. |
24b50df
into
openedx-unsupported:open-release/quince.master
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is a backport of #7046
With the current version of the pip (19.0.3) it is impossible to install the cryptography package with a version higher than 39.X.X (starting from the palm release it is 40+, source: https://github.com/openedx/tubular/blob/open-release/palm.3/requirements/base.txt#L47)
The issue could be resolved by either installing the rustc to build the package or upgrading the pip version to use the prebuild wheel which is the recommendation from the cryptography setup guide: https://cryptography.io/en/latest/installation/#building-cryptography-on-linux
In this PR I increased the pip version using the version pinned in the tubular requirements:
https://github.com/openedx/tubular/blob/master/requirements/pip.txt#L11
The pip version installation described here
https://github.com/openedx/configuration/blob/master/playbooks/roles/user_retirement_pipeline/tasks/main.yml#L34
Notes
Installing requirements from the
requirements/pip.txt
file instead of pinning the pip version in the configuration seems to be a better solution for me, but I decided to go with minimal changes for now.Here are the error logs for the issue: