From 61452a1fdd094b7d879d42ac6cef895ad5ee6faf Mon Sep 17 00:00:00 2001 From: Hamza Shafique Date: Thu, 12 Dec 2024 18:35:30 +0500 Subject: [PATCH] fix: ci_quality checks --- course_discovery/apps/api/v2/serializers.py | 13 ++++--------- .../search_indexes/serializers/aggregation.py | 6 +----- .../search_indexes/serializers/course.py | 4 +--- .../search_indexes/serializers/learner_pathway.py | 4 +--- .../search_indexes/serializers/program.py | 4 +--- 5 files changed, 8 insertions(+), 23 deletions(-) diff --git a/course_discovery/apps/api/v2/serializers.py b/course_discovery/apps/api/v2/serializers.py index 5495e85fdb..b7b8fb2ed5 100644 --- a/course_discovery/apps/api/v2/serializers.py +++ b/course_discovery/apps/api/v2/serializers.py @@ -1,23 +1,18 @@ from course_discovery.apps.course_metadata.search_indexes import documents from course_discovery.apps.course_metadata.search_indexes.constants import SEARCH_INDEX_ADDITIONAL_FIELDS_V2 from course_discovery.apps.course_metadata.search_indexes.documents import ( - CourseDocument, - CourseRunDocument, - LearnerPathwayDocument, - PersonDocument, - ProgramDocument, + CourseDocument, CourseRunDocument, LearnerPathwayDocument, PersonDocument, ProgramDocument ) from course_discovery.apps.course_metadata.search_indexes.serializers.aggregation import ( - AggregateSearchListSerializer, - AggregateSearchSerializer, + AggregateSearchListSerializer, AggregateSearchSerializer ) from course_discovery.apps.course_metadata.search_indexes.serializers.common import SortFieldMixin from course_discovery.apps.course_metadata.search_indexes.serializers.course import CourseSearchDocumentSerializer from course_discovery.apps.course_metadata.search_indexes.serializers.course_run import ( - CourseRunSearchDocumentSerializer, + CourseRunSearchDocumentSerializer ) from course_discovery.apps.course_metadata.search_indexes.serializers.learner_pathway import ( - LearnerPathwaySearchDocumentSerializer, + LearnerPathwaySearchDocumentSerializer ) from course_discovery.apps.course_metadata.search_indexes.serializers.person import PersonSearchDocumentSerializer from course_discovery.apps.course_metadata.search_indexes.serializers.program import ProgramSearchDocumentSerializer diff --git a/course_discovery/apps/course_metadata/search_indexes/serializers/aggregation.py b/course_discovery/apps/course_metadata/search_indexes/serializers/aggregation.py index 19a0521851..32b86e530a 100644 --- a/course_discovery/apps/course_metadata/search_indexes/serializers/aggregation.py +++ b/course_discovery/apps/course_metadata/search_indexes/serializers/aggregation.py @@ -5,9 +5,7 @@ from course_discovery.apps.api.serializers import COMMON_IGNORED_FIELDS from course_discovery.apps.course_metadata.search_indexes import documents from course_discovery.apps.edx_elasticsearch_dsl_extensions.serializers import ( - BaseDjangoESDSLFacetSerializer, - DummyDocument, - MultiDocumentSerializerMixin, + BaseDjangoESDSLFacetSerializer, DummyDocument, MultiDocumentSerializerMixin ) from .course import CourseSearchDocumentSerializer, CourseSearchModelSerializer @@ -124,5 +122,3 @@ class Meta: list_serializer_class = AggregateSearchListSerializer document = DummyDocument ignore_fields = COMMON_IGNORED_FIELDS - - diff --git a/course_discovery/apps/course_metadata/search_indexes/serializers/course.py b/course_discovery/apps/course_metadata/search_indexes/serializers/course.py index 3887b55a31..b8e277dd0c 100644 --- a/course_discovery/apps/course_metadata/search_indexes/serializers/course.py +++ b/course_discovery/apps/course_metadata/search_indexes/serializers/course.py @@ -16,9 +16,7 @@ from ..constants import BASE_SEARCH_INDEX_FIELDS, COMMON_IGNORED_FIELDS from ..documents import CourseDocument -from .common import ( - DateTimeSerializerMixin, DocumentDSLSerializerMixin, ModelObjectDocumentSerializerMixin -) +from .common import DateTimeSerializerMixin, DocumentDSLSerializerMixin, ModelObjectDocumentSerializerMixin __all__ = ('CourseSearchDocumentSerializer',) diff --git a/course_discovery/apps/course_metadata/search_indexes/serializers/learner_pathway.py b/course_discovery/apps/course_metadata/search_indexes/serializers/learner_pathway.py index c2e8d1a9ce..79a12c5394 100644 --- a/course_discovery/apps/course_metadata/search_indexes/serializers/learner_pathway.py +++ b/course_discovery/apps/course_metadata/search_indexes/serializers/learner_pathway.py @@ -10,9 +10,7 @@ from ..constants import BASE_SEARCH_INDEX_FIELDS, COMMON_IGNORED_FIELDS from ..documents import LearnerPathwayDocument -from .common import ( - DateTimeSerializerMixin, DocumentDSLSerializerMixin, ModelObjectDocumentSerializerMixin -) +from .common import DateTimeSerializerMixin, DocumentDSLSerializerMixin, ModelObjectDocumentSerializerMixin __all__ = ('LearnerPathwaySearchDocumentSerializer',) diff --git a/course_discovery/apps/course_metadata/search_indexes/serializers/program.py b/course_discovery/apps/course_metadata/search_indexes/serializers/program.py index ec4e951bc7..dca41e3c70 100644 --- a/course_discovery/apps/course_metadata/search_indexes/serializers/program.py +++ b/course_discovery/apps/course_metadata/search_indexes/serializers/program.py @@ -9,9 +9,7 @@ from course_discovery.apps.course_metadata.utils import get_product_skill_names from course_discovery.apps.edx_elasticsearch_dsl_extensions.serializers import BaseDjangoESDSLFacetSerializer -from ..constants import ( - BASE_PROGRAM_FIELDS, BASE_SEARCH_INDEX_FIELDS, COMMON_IGNORED_FIELDS -) +from ..constants import BASE_PROGRAM_FIELDS, BASE_SEARCH_INDEX_FIELDS, COMMON_IGNORED_FIELDS from ..documents import ProgramDocument from .common import DocumentDSLSerializerMixin