-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade dependencies and ruby minor version #416
Conversation
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
18e933a
to
925d883
Compare
b0d79bb
to
1ee2b58
Compare
5856921
to
5e0f292
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 58 58
Lines 4562 4562
=======================================
Hits 4386 4386
Misses 176 176 ☔ View full report in Codecov by Sentry. |
Hi @ghassanmas, thanks for the contribution! Let us know when the changes are ready for review please. |
Hey @ghassanmas, just checking in to see if you're still planning to continue working on this PR? |
@itsjeyd Apologies for the late reply, I can confirm this has been tested, and to my end it's ready for review |
@ghassanmas No problem, and thanks for the update! It looks like one of the required checks didn't run for some reason. Do you have any idea why? If not, would you mind rebasing your changes and pushing them again to trigger another build? |
@itsjeyd I am not really sure, but I can retriigger the test... |
4258cb8
to
c207f72
Compare
@ghassanmas Hm ... 🤔 Looks like that didn't do the trick. @e0d Do you have any idea what might be happening here? |
Hey @ghassanmas, looks like master was updated with some conflicting changes. Maybe you could try rebasing again and see if that helps with getting remaining checks to run? |
fb33e43
to
d9d9fda
Compare
d9d9fda
to
e55948a
Compare
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This change does the following (for
Gemfile3
)It update the dependencies via
BUNDLE_GEMFILE=Gemfile3 bundle update
It runs the tests on ruby
3.0.6
iatest release versionThis pull request is not tested yet.
After merge, backport to pam