Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move on from deprecated pkg_resources api #481

Closed
farhan opened this issue Aug 26, 2024 · 4 comments
Closed

Move on from deprecated pkg_resources api #481

farhan opened this issue Aug 26, 2024 · 4 comments
Labels
maintenance Routine upkeep necessary for the health of the platform

Comments

@farhan
Copy link

farhan commented Aug 26, 2024

Shift the code from pkg_resources to importlib.resources api

Migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html
Decision making story: openedx/XBlock#676
Reference PR to take learning from: https://github.com/openedx/xblock-sdk/pull/350/files

Prerequisites:

Acceptance Criteria:

  • Make sure the repository is using xblock version 5.0.0 or above. Upgrade the version if required, preferably via the make upgrade command.
  • There should be no usage of pkg_resources in the repository
  • Test cases should be passed
  • XBlock should perform all of its functionality related to change (loading resources)
@farhan farhan added the maintenance Routine upkeep necessary for the health of the platform label Aug 26, 2024
@abdullahQureshee
Copy link

Please assign this to me.

@farhan
Copy link
Author

farhan commented Oct 23, 2024

@abdullahQureshee Following PR is already in code review, please look into it, we can close it I think
#471

@abdullahQureshee
Copy link

@abdullahQureshee Following PR is already in code review, please look into it, we can close it I think #471

lgtm

@farhan
Copy link
Author

farhan commented Oct 23, 2024

Let's close the issue, once following PR will be merged:
#471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Routine upkeep necessary for the health of the platform
Projects
None yet
Development

No branches or pull requests

3 participants