Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable CI for pull requests #1978

Conversation

0x29a
Copy link
Contributor

@0x29a 0x29a commented Jan 3, 2024

This change enables CI checks for PRs targeted against branches other than master.

This is useful for stacked PRs, as it allows to run checks for all dependent PRs.

@openedx-webhooks
Copy link

openedx-webhooks commented Jan 3, 2024

Thanks for the pull request, @0x29a!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-unmaintained. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: we've been applying this change manually to our branches since Nutmeg
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a

@Agrendalath
Copy link
Member

@e0d, would you be able to help with merging this?

@e0d
Copy link

e0d commented Jan 3, 2024

@georgebabey any reason not to merge this?

@mphilbrick211
Copy link

@georgebabey any reason not to merge this?

Hi @georgebabey - bumping this!

@0x29a
Copy link
Contributor Author

0x29a commented Mar 28, 2024

@georgebabey, @mphilbrick211, just checking: if the change if fine, can we possibly merge this? Here is an example of a chained pull request where this fix would be helpful. You can see that tests aren't being run for it.

@mphilbrick211
Copy link

@georgebabey, @mphilbrick211, just checking: if the change if fine, can we possibly merge this? Here is an example of a chained pull request where this fix would be helpful. You can see that tests aren't being run for it.

Hi @0x29a - I'm looking into getting this reviewed for you.

@georgebabey
Copy link
Contributor

georgebabey commented Apr 2, 2024

Apologies for the delay, happy to get this merged, but it is out of date with base branch now

@0x29a 0x29a force-pushed the 0x29a/enable-ci-for-pull-requests-against-non-master-branches branch from 010a7e8 to b8e901b Compare April 3, 2024 08:39
@0x29a
Copy link
Contributor Author

0x29a commented Apr 3, 2024

Thank you, @georgebabey and @mphilbrick211! I re-based the branch.

@0x29a 0x29a force-pushed the 0x29a/enable-ci-for-pull-requests-against-non-master-branches branch from b8e901b to ccc68ae Compare April 17, 2024 14:43
@0x29a 0x29a force-pushed the 0x29a/enable-ci-for-pull-requests-against-non-master-branches branch from 13af747 to 53bf5c5 Compare May 2, 2024 13:05
@bradenmacdonald
Copy link
Contributor

@georgebabey Could you please hit merge here?

@e0d
Copy link

e0d commented Jun 7, 2024

@bradenmacdonald I noticed the branch is out of date, can you update?

@bradenmacdonald
Copy link
Contributor

@e0d Sure, I pressed the update button. That's weird you couldn't, because I know GitHub has functionality to allow maintainers to update PRs even from private forks. I've used it myself as a maintainer on other projects. Maybe there's a setting we need to turn on for this repo?

@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Jul 30, 2024
@itsjeyd
Copy link
Contributor

itsjeyd commented Nov 28, 2024

@tecoholic @0x29a Is this PR still needed? And if so, could you please rebase it?

Since @georgebabey approved the changes earlier, I'm assuming we can merge them once the build is green.

CC @mphilbrick211

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Nov 28, 2024
@georgebabey georgebabey merged commit ec072b8 into openedx:master Nov 28, 2024
10 checks passed
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 28, 2024
@itsjeyd
Copy link
Contributor

itsjeyd commented Nov 28, 2024

That was quick, thanks @georgebabey and @0x29a 👍

@bradenmacdonald bradenmacdonald deleted the 0x29a/enable-ci-for-pull-requests-against-non-master-branches branch November 28, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants