-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add register intent prop for login segement call
Description: Add register intent property for login successful segement call VAN-1929
- Loading branch information
Ahtesham Quraish
committed
Jun 3, 2024
1 parent
f3413fd
commit 437f4d4
Showing
2 changed files
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1041,6 +1041,7 @@ class LoginSessionViewTest(ApiTestCase, OpenEdxEventsTestMixin): | |
USERNAME = "bob" | ||
EMAIL = "[email protected]" | ||
PASSWORD = "password" | ||
REGISTER_INTENT = True | ||
|
||
@classmethod | ||
def setUpClass(cls): | ||
|
@@ -1117,6 +1118,7 @@ def test_login(self, include_analytics, mock_segment): | |
data = { | ||
"email": self.EMAIL, | ||
"password": self.PASSWORD, | ||
"register_intent": self.REGISTER_INTENT, | ||
} | ||
if include_analytics: | ||
track_label = "edX/DemoX/Fall" | ||
|
@@ -1145,7 +1147,7 @@ def test_login(self, include_analytics, mock_segment): | |
mock_segment.track.assert_called_once_with( | ||
expected_user_id, | ||
'edx.bi.user.account.authenticated', | ||
{'category': 'conversion', 'provider': None, 'label': track_label} | ||
{'category': 'conversion', 'provider': None, 'label': track_label, 'register_intent': True} | ||
) | ||
|
||
def test_login_with_username(self): | ||
|