Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to notify credentials about honor certificates #32633

Conversation

DmytroAlipov
Copy link
Contributor

Description

Honor mode is absent by default in the course list for "Program Records" that appears error for "Program Records" for users with permission "Active" after clicking on "View My Records" button:

screen_5

500 error appeared

Implemented:

  • Developed solution for adding course mode "Honor" to the list of modes for "Program Records"
  • "Earned" and "completed" status are set up for Honor Courses and Program after finishing the program for staff and particular user

Added a WaffleFlag course_modes.extend_certificate_relevant_modes_with_honor. When enabled - credential will receive data about the HONOR course certificates.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 3, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 3, 2023

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 5, 2023
@mphilbrick211
Copy link

Hi @openedx/2u-aperture! Is this something you could review/merge?

@justinhynes
Copy link
Contributor

I added an internal ticket for tracking and prioritization purposes -- APER-2691.

@hurtstotouchfire hurtstotouchfire self-assigned this Aug 30, 2023
@hurtstotouchfire hurtstotouchfire added product review PR requires product review before merging and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Aug 30, 2023
@mphilbrick211
Copy link

mphilbrick211 commented Aug 31, 2023

@jmakowski1123 - Per Kelly's comment here, would you mind adding this to your product review queue? Thanks!

#32745 is the backport for this (which Kelly moved to a draft until product review is complete on this one)

@mphilbrick211
Copy link

Hi @DmytroAlipov! Flagging the new tests that have popped up, per the recent update: https://discuss.openedx.org/t/minor-change-to-edx-platform-check-statuses/11131

@mphilbrick211
Copy link

Hi @jmakowski1123! Is there a roadmap ticket for this yet (for Product review)?

@DmytroAlipov DmytroAlipov force-pushed the notify-credentials-about-honor-certificates branch from eb5c2ff to 25561c6 Compare October 3, 2023 07:37
@mphilbrick211
Copy link

Hi @jmakowski1123! Is there a roadmap ticket for this yet (for Product review)?

@jmakowski1123 - following up on this

@DmytroAlipov DmytroAlipov force-pushed the notify-credentials-about-honor-certificates branch 2 times, most recently from cb7dcbf to ce3a646 Compare October 4, 2023 06:24
@jmakowski1123
Copy link

This is approved. I think it should remain behind a flag to allow operators the flexibility to decide how and when credentials obtained in honor mode should be displayed, particularly because use cases for the honor mode are varied.

@mphilbrick211
Copy link

This is approved. I think it should remain behind a flag to allow operators the flexibility to decide how and when credentials obtained in honor mode should be displayed, particularly because use cases for the honor mode are varied.

@ihor-romaniuk FYI ^

@mphilbrick211
Copy link

@justinhynes @openedx/2u-aperture - this is all set from Product and ready for review.

@mphilbrick211 mphilbrick211 requested review from a team and removed request for jmakowski1123 December 15, 2023 19:24
@jsnwesson jsnwesson added product review PR requires product review before merging and removed product review PR requires product review before merging labels Feb 14, 2024
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 14, 2024
@jsnwesson
Copy link
Contributor

@mphilbrick211 I'll be bringing this up with the team next Tuesday! Ideally we'll be able to prioritize it for the following sprint.

@jsnwesson jsnwesson added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Feb 14, 2024
@mphilbrick211
Copy link

Thank you, @jsnwesson!

@justinhynes
Copy link
Contributor

I plan on taking a look at this PR today. Thanks for your patience.

@justinhynes justinhynes self-assigned this Feb 27, 2024
@DmytroAlipov DmytroAlipov force-pushed the notify-credentials-about-honor-certificates branch 3 times, most recently from 8554b48 to 41fd2e3 Compare March 20, 2024 10:42
@DmytroAlipov
Copy link
Contributor Author

Hi @justinhynes
Following your advice, I used is_eligible_for_certificate. Indeed, this also works correctly.
This allowed us not to add a new WaffleFlag.

Regarding the question Was there a reason the existing functionality wasn't sufficient in the notify_credentials work flow?, the service LMS does not notify Credentials about the user receiving Honor's certificates.

Without changes in the code, we get the following result when going to the “Program Record” page:
screen_36

With changes:
screen_37

@DmytroAlipov DmytroAlipov force-pushed the notify-credentials-about-honor-certificates branch from 41fd2e3 to 36447aa Compare March 20, 2024 11:04
@mphilbrick211 mphilbrick211 added product review complete PR has gone through product review and removed product review PR requires product review before merging labels Mar 29, 2024
@justinhynes
Copy link
Contributor

Thanks for the update here, this should be prioritized for review shortly.

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @DmytroAlipov! Looks good, I've approved it but there are a few conflicts before merge. Any chance you can fix those up and then I'll ensure this gets merged?

@DmytroAlipov DmytroAlipov force-pushed the notify-credentials-about-honor-certificates branch 4 times, most recently from 99b889d to 834a0ff Compare April 3, 2024 16:06
@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Apr 3, 2024
@mphilbrick211
Copy link

@justinhynes - this is a backport to #32745 which has been closed. Can this be closed as well?

@justinhynes
Copy link
Contributor

Hi @mphilbrick211, I'm just a little confused. I am keeping an eye on this PR and once the tests pass, I can merge it. I wasn't planning on closing this PR without merging though.

I did close the backport of this change to Palm, as Palm is quite old now.

@DmytroAlipov DmytroAlipov force-pushed the notify-credentials-about-honor-certificates branch from 834a0ff to 1f1efbb Compare April 3, 2024 17:50
@DmytroAlipov
Copy link
Contributor Author

@justinhynes Finally, all tests passed successfully😅

@justinhynes justinhynes merged commit 03a490f into openedx:master Apr 4, 2024
67 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the notify-credentials-about-honor-certificates branch April 4, 2024 12:43
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants