-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to notify credentials about honor certificates #32633
feat: add ability to notify credentials about honor certificates #32633
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @openedx/2u-aperture! Is this something you could review/merge? |
I added an internal ticket for tracking and prioritization purposes -- APER-2691. |
@jmakowski1123 - Per Kelly's comment here, would you mind adding this to your product review queue? Thanks! #32745 is the backport for this (which Kelly moved to a draft until product review is complete on this one) |
Hi @DmytroAlipov! Flagging the new tests that have popped up, per the recent update: https://discuss.openedx.org/t/minor-change-to-edx-platform-check-statuses/11131 |
Hi @jmakowski1123! Is there a roadmap ticket for this yet (for Product review)? |
eb5c2ff
to
25561c6
Compare
@jmakowski1123 - following up on this |
cb7dcbf
to
ce3a646
Compare
This is approved. I think it should remain behind a flag to allow operators the flexibility to decide how and when credentials obtained in honor mode should be displayed, particularly because use cases for the honor mode are varied. |
@ihor-romaniuk FYI ^ |
@justinhynes @openedx/2u-aperture - this is all set from Product and ready for review. |
@mphilbrick211 I'll be bringing this up with the team next Tuesday! Ideally we'll be able to prioritize it for the following sprint. |
Thank you, @jsnwesson! |
I plan on taking a look at this PR today. Thanks for your patience. |
8554b48
to
41fd2e3
Compare
Hi @justinhynes Regarding the question Without changes in the code, we get the following result when going to the “Program Record” page: |
41fd2e3
to
36447aa
Compare
Thanks for the update here, this should be prioritized for review shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @DmytroAlipov! Looks good, I've approved it but there are a few conflicts before merge. Any chance you can fix those up and then I'll ensure this gets merged?
99b889d
to
834a0ff
Compare
@justinhynes - this is a backport to #32745 which has been closed. Can this be closed as well? |
Hi @mphilbrick211, I'm just a little confused. I am keeping an eye on this PR and once the tests pass, I can merge it. I wasn't planning on closing this PR without merging though. I did close the backport of this change to Palm, as Palm is quite old now. |
834a0ff
to
1f1efbb
Compare
@justinhynes Finally, all tests passed successfully😅 |
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Honor mode is absent by default in the course list for "Program Records" that appears error for "Program Records" for users with permission "Active" after clicking on "View My Records" button:
500 error appeared
Implemented:
Added a WaffleFlag course_modes.extend_certificate_relevant_modes_with_honor. When enabled - credential will receive data about the HONOR course certificates.