Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent for Palm #32688

Conversation

DmytroAlipov
Copy link
Contributor

Description

This is a backport from the master branch.

[Instructor Dashboard > Membership] Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent

Steps to Reproduce:

  1. Go to the Instructor Dashboard > Membership
  2. Leave input field for Batch Enrollment empty
  3. Click on [Enroll] button

screen_14

screen_15

Another bug found:

  • if you add invalid users to Batch Enrollment:
screen_12
  • if you add invalid users to Batch Beta Tester Addition:
screen_13

Now everything works correctly:

screen_16 screen_17

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 7, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 7, 2023

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DmytroAlipov DmytroAlipov force-pushed the fix-error-for-empty-list-enrollment-palm branch from d044342 to e25db23 Compare July 13, 2023 06:04
@DmytroAlipov DmytroAlipov changed the title fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent for Palm WIP: fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent for Palm Jul 18, 2023
@DmytroAlipov DmytroAlipov force-pushed the fix-error-for-empty-list-enrollment-palm branch from e25db23 to dd2ef11 Compare July 18, 2023 11:07
@DmytroAlipov DmytroAlipov changed the title WIP: fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent for Palm fix: Validation error for "empty" Batch Enrollment, Batch Beta Tester Addition fields is absent for Palm Jul 18, 2023
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Would someone be able to merge this for us?

@mphilbrick211 mphilbrick211 requested a review from a team July 25, 2023 20:47
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 7, 2023
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Putting this back on the radar - would someone be able to please review and merge? Thanks!

@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Putting this back on the radar - would someone be able to please review and merge? Thanks!

Hi @openedx/teaching-and-learning - is there an ETA you can provide for review on this?

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Feb 23, 2024

Hi there, @DmytroAlipov; since there will not be another Palm release according to the Open edX release schedule, I'll close this PR in the name of BTR. You can open a backport PR to the Quince branch to include these changes in the next release or wait until Redwood. Thanks!

@openedx-webhooks
Copy link

@DmytroAlipov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-error-for-empty-list-enrollment-palm branch March 21, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants