Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass required context for instructor emails (Palm) #32742

Closed
wants to merge 1 commit into from
Closed

feat: pass required context for instructor emails (Palm) #32742

wants to merge 1 commit into from

Conversation

DmytroAlipov
Copy link
Contributor

Description

backport from master

Pass required context to bulk enrollment emails:

  • logo_url
  • homepage_url
  • dashboard_url

Add additional context for enrollment emails:

  • contact_email
  • platform_name

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 14, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 14, 2023 •
edited
Loading

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DmytroAlipov
feat: pass required context for instructor emails
1d96c03 
pass required context to bulk enrollment emails:
  - logo_url
  - homepage_url
  - dashboard_url
add additional context for enrollment emails:
  - contact_email
  - platform_name
@mphilbrick211 mphilbrick211 requested a review from a team July 25, 2023 20:49
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Would someone be able to please review/merge this for us? Thanks!

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 7, 2023
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning - friendly ping on this!

@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning - friendly ping on this!

Hi @openedx/teaching-and-learning! Getting this back on the radar.

@mariajgrimaldi
Copy link
Member

@DmytroAlipov: since there will not be another release for palm, should we close this PR then?

@mariajgrimaldi
Copy link
Member

Hi there, @DmytroAlipov; as I mentioned before, there will not be another Palm release according to the Open edX release schedule, so I'll close this PR in the name of BTR. You can open a backport PR to the Quince branch to include these changes in the next release or wait until Redwood. Thanks!

@openedx-webhooks
Copy link

@DmytroAlipov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the add-required-context-for-instructor-emails-palm branch March 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DmytroAlipov @openedx-webhooks @mphilbrick211 @mariajgrimaldi