Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated bleach package #33209

Closed
jmbowman opened this issue Sep 8, 2023 · 0 comments · Fixed by #34811
Closed

Replace deprecated bleach package #33209

jmbowman opened this issue Sep 8, 2023 · 0 comments · Fixed by #34811
Assignees
@irtazaakram

Comments

@jmbowman
Copy link
Contributor

jmbowman commented Sep 8, 2023

The bleach package was deprecated as of 2023-01-23 because the underlying html5lib package is essentially no longer being developed: mozilla/bleach#698 . The best suggested replacement so far is https://github.com/messense/nh3 , a Python wrapper for https://github.com/rust-ammonia/ammonia (a Rust library which was in turn inspired by bleach); one recent example of a package migrating to it is pypa/readme_renderer#295 .

We should determine if nh3 is a suitable replacement for bleach in edx-platform, and if so attempt the replacement.
@jmbowman jmbowman added this to Arbi-BOM Sep 8, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Arbi-BOM Sep 8, 2023
@jmbowman jmbowman moved this from Backlog to Todo in Arbi-BOM Sep 8, 2023
@irtazaakram irtazaakram self-assigned this Dec 13, 2023
@iamsobanjaved iamsobanjaved moved this from Todo to In Progress in Arbi-BOM Dec 18, 2023
@irtazaakram irtazaakram mentioned this issue Jan 2, 2024
Closed
@irtazaakram irtazaakram removed their assignment Apr 30, 2024
@feanil feanil moved this to 🆕 New in Aximprovements Team May 2, 2024
@farhan farhan moved this from 🆕 New to 📋 Backlog in Aximprovements Team May 7, 2024
@irtazaakram irtazaakram moved this from 📋 Backlog to 🔖 Ready in Aximprovements Team May 9, 2024
@irtazaakram irtazaakram moved this from 🔖 Ready to 🏗 In progress in Aximprovements Team May 14, 2024
@irtazaakram irtazaakram mentioned this issue May 16, 2024
Merged
@irtazaakram irtazaakram moved this from 🏗 In progress to 👀 In review in Aximprovements Team May 28, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Arbi-BOM Jun 13, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Aximprovements Team Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irtazaakram irtazaakram

Labels
None yet
Projects
Aximprovements Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated bleach package irtazaakram/edx-platform
2 participants
@jmbowman @irtazaakram