make upgrade fails in devstack for lms-shell
#33287
Assignees
Comments
timmc-edx
added a commit
that referenced
this issue
Sep 19, 2023
It's needed by `make common_constraints.txt`. We're starting to see failures running this command in lms-shell in devstack. This has probably been going on the entire time, but the error suppression was only removed recently in <#33271>. The new RUN instruction for installing wget is added to the development layer only, partly to limit image sizes and partly to make life harder for any attacker who manages to gain code execution in production. I've moved `USER app` from the end of the `base` layer to the start of the `production` layer, since the only other layer (in this file) that builds on `base` is `development`, which more or less immediately switches back to root. (The intervening COPY instruction is not affected by the current user.) Ticket: #33287
|
Fixing with #33288 |
timmc-edx
added a commit
that referenced
this issue
Sep 19, 2023
It's needed by `make common_constraints.txt`. We're starting to see failures running this command in lms-shell in devstack. This has probably been going on the entire time, but the error suppression was only removed recently in <#33271>. The new RUN instruction for installing wget is added to the development layer only, partly to limit image sizes and partly to make life harder for any attacker who manages to gain code execution in production. I've moved `USER app` from the end of the `base` layer to the start of the `production` layer, since the only other layer (in this file) that builds on `base` is `development`, which more or less immediately switches back to root. (The intervening COPY instruction is not affected by the current user.) Ticket: #33287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The command
make upgradefails for edxapp in lms-shell because the wget package is missing.wget is used by the
common_constraints.txtmake target. We recently started to see failures running this command in lms-shell in devstack. This has probably been going on the entire time, but the error suppression was only removed recently in #33271.The text was updated successfully, but these errors were encountered: