Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent probably-unnecessary error in TPA next-URL login code that causes some SafeSession mismatches #33315

Open
robrap opened this issue Sep 21, 2023 · 1 comment

Comments

@robrap
Copy link
Contributor

robrap commented Sep 21, 2023

We think that when running_pipeline is None, we should probably just skip setting a finish_auth_url and log a warning:

finish_auth_url = pipeline.get_complete_url(backend_name=running_pipeline['backend'])

Theory: When an error is thrown here ('NoneType' object is not subscriptable), the user gets a new, valid session cookie but keeps their old JWT cookies, which causes a mismatch.

We’re not sure whether running_pipeline is expected to sometimes be None, so the warning may not even be appropriate, but we should have a warning here until such time as someone determines that it can be removed.

Note: This was moved here from this 2U private-link ticket.

@robrap
Copy link
Contributor Author

robrap commented Sep 21, 2023

We think this might be simple to fix, but has not been deemed a high enough priority. I created a starter PR for this: #29853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant