Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dependencies #33326

Closed

Conversation

LakshyaKhatri
Copy link
Contributor

@LakshyaKhatri LakshyaKhatri commented Sep 22, 2023

Description

We ran depslorer on the edx-platform and found a few dependencies that are no longer needed in the repo. This PR aims to remove those dependencies from edx-platform.

Supporting information

Closes #32604
Please check above issue for information on the output from Depslorer.

Testing instructions

Please ensure that all tests should still pass after removing these dependencies.

Deadline

None

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 22, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 22, 2023

Thanks for the pull request, @LakshyaKhatri! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@LakshyaKhatri LakshyaKhatri marked this pull request as draft September 22, 2023 17:11
@LakshyaKhatri
Copy link
Contributor Author

LakshyaKhatri commented Sep 22, 2023

@dianakhuang, I see there's a slight issue with removing diff-cover. Some of the testing pipelines are using it to generate coverage reports. Here's an example of how the js-testing pipeline calls are being made to diff-cover:

  1. https://github.com/openedx/edx-platform/blob/f9148f032fc93bd339fb0ab50afb5cb3b1cdca21/.github/workflows/js-tests.yml#L69C1-L70

  2. $TOX paver diff_coverage

  3. def diff_coverage(options):
    """
    Build the diff coverage reports
    """
    compare_branch = options.get('compare_branch', 'origin/master')

  4. sh(
    "diff-cover {xml_report_str} --diff-range-notation '..' --compare-branch={compare_branch} "
    "--html-report {diff_html_path}".format(
    xml_report_str=xml_report_str,
    compare_branch=compare_branch,
    diff_html_path=diff_html_path,
    )
    )

@LakshyaKhatri LakshyaKhatri changed the title Draft: chore: remove unused dependencies chore: remove unused dependencies Sep 24, 2023
@LakshyaKhatri LakshyaKhatri marked this pull request as ready for review September 24, 2023 05:53
@mphilbrick211
Copy link

Hi @LakshyaKhatri! Before getting this reviewed, would you mind taking a look at the failing check? Please let me know if you have any questions. Thanks!

@mphilbrick211
Copy link

Hi @LakshyaKhatri! Before getting this reviewed, would you mind taking a look at the failing check? Please let me know if you have any questions. Thanks!

Hi @LakshyaKhatri! Just following up on this :)

@mphilbrick211
Copy link

Hi @LakshyaKhatri - Just following up to see if you plan to pursue this pull request?

@mphilbrick211
Copy link

Hi @LakshyaKhatri - I'm going to close this pull request for now, though we can reopen if you would like to pursue at a later date. Thanks!

@openedx-webhooks
Copy link

@LakshyaKhatri Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Run depsplorer on edx-platform
3 participants