Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid Blockstore access in LMS #33545

Closed
kdmccormick opened this issue Oct 19, 2023 · 3 comments
Closed

Forbid Blockstore access in LMS #33545

kdmccormick opened this issue Oct 19, 2023 · 3 comments

Comments

@kdmccormick
Copy link
Member

Background

The ADR "Limit LMS Modulestore access to the courseware app" explains why we want to limit and eventually remove the ability for LMS to access Modulestore. These same logic applies to Blockstore: we want Blockstore to be an authoring-only data store, with its content pushed into dedicated LMS models tailored to learning and instruction.

Currently, Blockstore is installed into both LMS and CMS, and there a few places where Blockstore can be accessed from LMS, such as the library_tools service. As of 2023, the number of these usage is fairly low, so now's a good time to tackle the issue before it gets more widespread.

Tasks

  • Write docs explaining why Blockstore should only be used in the CMS
  • Use tools like import-linting and ensure_cms() to find places where LMS uses Blockstore.
  • Remove those LMS usages. Notes:
    • This can include: removing the library_tools service from the LMS xblock runtime.
    • Some LMS unit tests rely on being able to write to and read from block store in order to create their test data. We'll need to find a better way to create data for those tests.
  • Un-install Blockstore from LMS.
@kdmccormick
Copy link
Member Author

FYI @ormsbee , @connorhaugh

@kdmccormick
Copy link
Member Author

kdmccormick commented Oct 19, 2023

Relates to:

@kdmccormick
Copy link
Member Author

Blockstore was removed from edx-platform.

@kdmccormick kdmccormick closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant