Lytvynenko/changed link parsing

[Inferato]

Since social URLs can be not only as a {social_media}/{username} we need to allow the use of any profile links

Closed:#33499
Related: open-release/quince.master

[openedx-webhooks]

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[mphilbrick211]

Hi @Inferato! Just flagging that there are some failing checks.

[mariajgrimaldi]

Hi there @Inferato: could you add testing instructions to the cover letter? Thanks!

[dyudyunov]

Hi there @Inferato: could you add testing instructions to the cover letter? Thanks!

Hi @mariajgrimaldi

Taras can't longer lead this PR (and the rest, if any)

I will take it under my care ASAP (or try to find someone to do so).

Sorry for inconveniences

[mariajgrimaldi]

@dyudyunov: thank you for the heads up!

[dyudyunov]

Hello @mariajgrimaldi

I can't edit the PR description, so I will leave testing instructions as a comment.

Steps to reproduce:

1. Open the Profile page for the user (age should be set to more than 13)
2. In Social links click on Edit
3. In the Facebook field fill in a standard link to your Facebook profile - containing the "?" sign (e.g https://www.facebook.com/profile.php?id=100003058112229) - it could be taken from the Facebook "Copy link to profile" setting, or by copying the URL from your browser manually. To get to your FB profile - click on your avatar and select the account name.
4. Save the FB profile link in the Profile MFE

ACTUAL RESULT:

in the link everything after the "?" sign was cut so the saved profile URL is incorrect and leads to the FB profile of the person who clicked the link instead of the person whose openedx profile it belongs to

EXPECTED RESULT:

The original link is saved, and the correct FB profile is opened

NOTES:

• it is also relevant for Twitter but for Twitter, it is possible to remove text after the "?" sign in the URL - it doesn't break anything and leads to the corresponding profile (e.g https://twitter.com/NASA?s=20)*
• reproduces on the Account page
• we've discovered and fixed these issues on the Palm release (our fork)
• I can't longer reproduce the issue and provide screenshots (without manipulations with our instance) because it is fixed on our instances

[MaxFrank13]

Hello all! Aperture has created a ticket to review this PR and will prioritize in the next ticket refinement session

[jsnwesson]

Hey all! I am on on-call this week for the Aperture team (@MaxFrank13 was on-call last week, hence his comment here).

I know there's a needs maintainer attention label that was attached to this two weeks ago, but I wanted to confirm with @mphilbrick211 if this is indeed ready for our review or if there's any remaining processes on your end.

[mphilbrick211]

Hey all! I am on on-call this week for the Aperture team (@MaxFrank13 was on-call last week, hence his comment here).

I know there's a needs maintainer attention label that was attached to this two weeks ago, but I wanted to confirm with @mphilbrick211 if this is indeed ready for our review or if there's any remaining processes on your end.

Hi @jsnwesson - We (the OSPR triage team), haven't used the "needs maintainer attention" - I think that was designated for internal 2U use. We have been using "needs engineering review" but I'm not sure how much it was helping. We can continue to use the "needs engineering review" as discussed in Slack.

In this situation however, it looks like @cmltaWt0 recently added a "product review label", so we need to get that sorted first. @cmltaWt0 - can you please clarify if this is something that has been added to the product roadmap board for review? Product needs to be alerted if this needs product review. It previously didn't need it so it was with Engineering for review. If that has changed, please let us know. Thanks!

[jsnwesson]

The needs eng review label should work fine, thanks for clarifying and looking into this!

[jmakowski1123]

I don't think this needs product review. I removed the label.

[mphilbrick211]

@jsnwesson this is now ready (along with its backport) for review. Product review is not needed. Thanks!

[MaxFrank13]

Thanks for doing this work. I tested locally and everything worked for me. I was able to successfully link an actual FB profile, rather than getting routed to my own.

[deborahgu]

Do you want @openedx/2u-aperture to merge this and the backport for you, or are you good now?

Edit: my understanding is that I should be doing this merge now, so I will go ahead and do that.

[openedx-webhooks]

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.