-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ORA response with attached file (for Quince) #33676
fix: ORA response with attached file (for Quince) #33676
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
d1ed96e
to
8775186
Compare
8775186
to
95477ac
Compare
Hi there @DmytroAlipov! We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against |
95477ac
to
69612c9
Compare
After clicking the "View all responses" button in the ORA Staff Grading App, an error page appears for ORAs with file uploads.
69612c9
to
b3ea3ce
Compare
Hi @mariajgrimaldi Additionally, I made the update for Palm, but the static check seems not to be functioning there. Does it require fixing? Considering that Palm tags are no longer being cut off. |
@DmytroAlipov: exactly, Palm.4 was the latest tag release so it's not worth it making it work there. I'll let the BTR know about this backport and then merge. Thanks! |
ba4bcf1
into
openedx:open-release/quince.master
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is a backport pull request to the master branch.
Description
The details are described in this discussion.
Now everything works correctly:
Do not pay attention to the fact that the screenshot was taken from a local instance. It has been tested on the production server, and everything works just as correctly.