Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: course about page markup and styles improvements #33711

Conversation

bydawen
Copy link
Contributor

@bydawen bydawen commented Nov 14, 2023

Similar PR is opened to the master branch:
#33712

There is some fixes for the course about page:

  • display a course short description in course about heading-group (if necessary)
  • removing duplicated pre-requisite info in right sidebar
  • code formatting for the block % if get_course_about_section(request, course, "prerequisites"):

Fixes were also made to the _course_about.scss styles, to fix responsive layout of the course about header element.

Before fixes:
1_before

After fixes:
2_after

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 14, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bydawen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bydawen
Copy link
Contributor Author

bydawen commented Nov 14, 2023

Hi! I'm contributing on behalf of Raccoongang

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 14, 2023
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@mariajgrimaldi
Copy link
Member

Hi there, @bydawen; since there will not be another Palm release according to the Open edX release schedule, I'll close this PR in the name of BTR. You can open a backport PR to the Quince branch to include these changes in the next release if you haven't already or wait until Redwood after your master PR is merged. Thanks!

@openedx-webhooks
Copy link

@bydawen Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants