-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: xblock asides view for rendering in an iframe in MFE #34026
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @Anas12091101! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @Anas12091101! Thanks for this contribution! Please let me know if you have any questions regarding submitting a CLA form. |
@mphilbrick211 Anas should be covered by the MIT Entity agreement. I don't know if you have access, but I've added him to the list at https://docs.google.com/spreadsheets/d/1HEaYDtoBtN-vvloA5UC-4oAHTVGzWbJWYVzYrEwFT4Y/edit#gid=755274227&range=28:28 |
Hi there @Anas12091101, can we list in the cover letter the PR against the master branch? Thanks! |
45823df
to
10c592a
Compare
Hi @mariajgrimaldi, I had not created a master PR previously. I have now rebased this PR to be merged into master. Will create a separate PR for quince branch |
5bb43f5
to
b12a0c7
Compare
b12a0c7
to
d83df5c
Compare
Hi @Anas12091101! Just following up on this, and flagging that there's a failing check. |
d83df5c
to
5f0baa1
Compare
Hi @mphilbrick211 , all the checks are now successful. |
@Anas12091101, do you know if this can this PR be tested with the Thumbs xBlock, which is included in the xBlock SDK? |
@pdpinch, this PR can be tested on any XBlock Aside that has a |
Hi @Anas12091101 @pdpinch - is this still in progress? |
Yes, it's still in progress. I'm still trying to find (or create) appropriate documentation for this feature so that it won't be so obscure. |
Is there a way this could be handled with a plugin slot? |
From my understanding, plugin slots can be used to customize MFE components. I believe we can modify our authoring MFE PR (which was closed and needs to be reopened) to add an iframe plugin slot that loads the aside from |
@Anas12091101 @pdpinch is this still in progress? |
We still very much need it, but I think we need some guidance and consensus on the approach. |
Description
This PR allows retrieval of all asides associated with a given xblock usage key and renders them into an HTTP response template page. This capability becomes particularly relevant for utilization within an iframe in the course authoring Micro-Frontend (MFE), which presently lacks support for asides configuration.
For this a django view asides_handler is created which
wrap_asides
method and passes them as a context to theasides.html
template.The
wrap_asides
method generates an HTML wrapper for each aside, which can be rendered within an HTML template containing information necessary for loading the aside. Subsequently, BackboneJS loads the asides into the wrapper. The xblock itself is rendered in a similar manner.Note: The approach used in this PR is inspired by the rendering of xblocks in the learning MFE.
Useful information to include:
Supporting information
Related Issue openedx/frontend-app-authoring#545
MFE PR openedx-unsupported/frontend-lib-content-components#452
Testing instructions
Please provide detailed step-by-step instructions for testing this change.