Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add work experience field. #34034

Merged
merged 1 commit into from
Jan 11, 2024
Merged

feat: add work experience field. #34034

merged 1 commit into from
Jan 11, 2024

Conversation

attiyaIshaque
Copy link
Contributor

@attiyaIshaque attiyaIshaque commented Jan 10, 2024

Description

I have added a work experience field that will be shown on the front-end authn welcome page and also on the legacy account setting page.

Ticket

https://2u-internal.atlassian.net/browse/VAN-1788

How Has This Been Tested?
you can add settings in django admin site configuration like this

"extended_profile_fields": [
        "work_experience"
    ],
    "EXTRA_FIELD_OPTIONS": {
        "work_experience": [
            "0",
            "1",
            "2",
            "3",
            "4",
            "5",
            "6",
            "7",
            "8",
            "9",
            "10+"
        ]
    }

and the filed will be shown in welcome page of auth mfe and account settings.

@attiyaIshaque attiyaIshaque marked this pull request as ready for review January 10, 2024 11:43
@@ -268,7 +268,8 @@ def _get_extended_profile_fields():
platform_name=configuration_helpers.get_value("PLATFORM_NAME", settings.PLATFORM_NAME)
),
"profession": _("Profession"),
"specialty": _("Specialty")
"specialty": _("Specialty"),
"work_experience": _("Work experience")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be covered in tests. test_setting_views.py in test_context test

@attiyaIshaque attiyaIshaque merged commit 5b06de4 into master Jan 11, 2024
64 checks passed
@attiyaIshaque attiyaIshaque deleted the attiya/VAN-1788 branch January 11, 2024 10:53
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants