Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove Transifex calls for FC-0012 - OEP-58 #34184

Closed

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Feb 6, 2024

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

  • Removes direct use of tx pull and tx push commands
  • Remove source and language translations from the repositories, hence no .po or .mo files will be committed into the repos.
  • Remove Transifex related Makefile targets and configuration files.
  • Use the OEP-58 JavaScript translations from the Open edX platform does not apply
  • Remove transifex-client from requirements not available

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

## Keep this pull request as a draft to prevent an accidental merge. ##

Pre-merge checklist

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.cleanup branch from 888ed03 to 02c50f7 Compare February 19, 2024 12:28
@OmarIthawi
Copy link
Member

@shadinaif we need to remove the translation files as well, probably in another pull request and mark them in .gitignore to avoid having atlas pull get this the platform into a dirty git status as it does now.

extract_translations: ## extract localizable strings from sources
i18n_tool extract -v;
endif
i18n_tool extract
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

third party wiki and edx_proctoring_proctortrack need to be concatenated with django.po

@OmarIthawi
Copy link
Member

Thanks @shadinaif, closing in favor of #34355 .

@OmarIthawi OmarIthawi closed this Mar 12, 2024
@openedx-webhooks
Copy link

@shadinaif Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants