Add new management command to approve submitted ID verification attempts. #34340
Conversation
MichaelRoytman
force-pushed
the
mroytman/COSMO-210-idv-approval-management-command
branch
from
94376e5 to
a5a0e01
Compare
| help = 'Manually approves ID verifications for users with an ID verification attempt in the submitted state.' | ||
|
|
||
| def add_arguments(self, parser): | ||
| parser.add_argument( |
There was a problem hiding this comment.
I changed this to take a file of user IDs instead of emails to limit PII exposure. I also made it required, because I don't see us needing to call this command with a singular user ID (and creating a file with one user ID is trivial).
| failed_user_ids: list of user IDs for which a manual approval was not performed | ||
| """ | ||
| users = User.objects.filter(id__in=user_ids) | ||
| existing_id_verifications = SoftwareSecurePhotoVerification.objects.filter( |
There was a problem hiding this comment.
A user may have more than one SoftwareSecurePhotoVerification attempt, although it should be rare, because you're only allowed to have one pending name change at a time, if you're using the Name Affirmation feature. I believe it's safe to approve them all.
MichaelRoytman
force-pushed
the
mroytman/COSMO-210-idv-approval-management-command
branch
from
a5a0e01 to
c8e3a46
Compare
lms/djangoapps/verify_student/management/commands/approve_id_verifications.py
Show resolved
Hide resolved
lms/djangoapps/verify_student/management/commands/approve_id_verifications.py
Outdated
Show resolved
Hide resolved
MichaelRoytman
force-pushed
the
mroytman/COSMO-210-idv-approval-management-command
branch
from
c8e3a46 to
75d9a0e
Compare
… attempts This pull requests adds a new management command approve_id_verifications to manually approve submitted ID verification attempts (i.e. instances of the SoftwareSecurePhotoVerifications model).
MichaelRoytman
force-pushed
the
mroytman/COSMO-210-idv-approval-management-command
branch
from
75d9a0e to
56719e9
Compare
MichaelRoytman
deleted the
mroytman/COSMO-210-idv-approval-management-command
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Description
This pull requests adds a new management command
approve_id_verificationsto manually approve submitted ID verification attempts (i.e. instances of theSoftwareSecurePhotoVerifications model).Supporting information
Jira: COSMO-210 (private)
Testing instructions
SoftwareSecurePhotoVerificationmodel in thesubmittedstate. A good way to do this is via the Verified Name feature in the Account MFE.manage.py lms approve_id_verifications <path_to_file>.Deadline
None.
Other information
None.