Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Space around techers images on course about page #34357

Conversation

Lunyachek
Copy link
Contributor

Description

This is a strange bug. It is related to a typo in the inline styles style="margin:0 20 px 0" - there was a space between 20 and px in the course about page template, which is the default for new courses. These styles did not work, so we could not see the bug. Then, in this pull request - #32890 - this typo was fixed, and now we are observing this bug (as shown in the screenshot below). We believe that this margin is completely unnecessary for the <img> tag, as the border and margin are set on the parent div teacher-image

Before fix
Снимок экрана 2024-03-12 в 23 38 31

After fix
Снимок экрана 2024-03-12 в 17 08 20

Also RTL version
Снимок экрана 2024-03-12 в 23 49 48

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 12, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lunyachek this change makes sense to me.

We follow a rebasing workflow. Could I ask you to please rebase your branch atop Master, and when you use GitHub's update branch feature in the future, change it to use rebasing instead of merging master.

Please ping me when the rebase is good to go!

@Lunyachek Lunyachek force-pushed the lunyachek/fix/course-about-teacher-images-fix-master branch from 444693c to cfcd526 Compare April 10, 2024 20:14
@sarina
Copy link
Contributor

sarina commented Apr 10, 2024

@Lunyachek someone on my team advised me that you can follow the merge-master-into-your-branch strategy, you just need to squash your commits prior to merge. Sorry I didn't know that, but now we both do!

@sarina sarina merged commit b004fe0 into openedx:master Apr 11, 2024
66 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@Lunyachek Lunyachek deleted the lunyachek/fix/course-about-teacher-images-fix-master branch April 18, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants