Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass required context for instructor emails #34401

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from
Open

feat: pass required context for instructor emails #34401

wants to merge 1 commit into from
+11 −0

Conversation

DmytroAlipov
Copy link
Contributor

This is a backport from the master branch.

Pass required context to bulk enrollment emails:

  • logo_url
  • homepage_url
  • dashboard_url

Add additional context for enrollment emails:

  • contact_email
  • platform_name

There is no required context for openedx/core/djangoapps/ace_common/templates/ace_common/edx_ace/common/base_body.html:

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 20, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

feat: pass required context for instructor emails
ec313c9 
pass required context to bulk enrollment emails:
  - logo_url
  - homepage_url
  - dashboard_url
add additional context for enrollment emails:
  - contact_email
  - platform_name
@DmytroAlipov DmytroAlipov force-pushed the add-required-context-for-instructor-emails-quince branch from 68bee6a to ec313c9 Compare March 20, 2024 19:50
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 21, 2024
@mphilbrick211
Copy link

Hi @navinkarkera! I think you're reviewing the master PR for this. Would you mind looking at this backport after?

@DmytroAlipov
Copy link
Contributor Author

Hi @mphilbrick211
Is it possible to have someone review this MR so that this fix can be included in Quince 3?

@mphilbrick211
Copy link

Hi @mphilbrick211 Is it possible to have someone review this MR so that this fix can be included in Quince 3?

Hi @navinkarkera! Following up on this to see if you could review?

@navinkarkera
Copy link
Contributor

@mphilbrick211 Yes, once master PR is merged and I'll review and merge this one.
cc: @DmytroAlipov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navinkarkera navinkarkera Awaiting requested review from navinkarkera

Assignees
No one assigned
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Build-Test-Release Working Group
Status: Backlog
Contributions
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DmytroAlipov @openedx-webhooks @mphilbrick211 @navinkarkera