Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: [FC-0056] change default value for a Navigation sidebar toggle #34747

Merged
merged 1 commit into from
May 9, 2024
Merged

docs: [FC-0056] change default value for a Navigation sidebar toggle #34747

merged 1 commit into from
May 9, 2024

Conversation

GlugovGrGlib
Copy link
Member

Description

This small PR correct the toggle_default value for the toggle courseware.enable_navigation_sidebar

Supporting information

This feature is done as part of FC-0056. Related GH issue: openedx/platform-roadmap#329

Deadline

Redwood

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@GlugovGrGlib GlugovGrGlib requested a review from arbrandes May 9, 2024 05:28
arbrandes
arbrandes approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arbrandes arbrandes merged commit c5d94d2 into openedx:master May 9, 2024
79 checks passed
@openedx-webhooks
Copy link

@GlugovGrGlib 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

rayzhou-bit pushed a commit that referenced this pull request May 9, 2024
@GlugovGrGlib @rayzhou-bit
docs: change default value for a toggle to correct doc (#34747)
4b5c803
@GlugovGrGlib GlugovGrGlib mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrandes arbrandes arbrandes approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GlugovGrGlib @openedx-webhooks @edx-pipeline-bot @arbrandes