Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: freeze edx-sandbox requirements for redwood #34752

Conversation

cmltaWt0
Copy link
Contributor

@cmltaWt0 cmltaWt0 commented May 9, 2024

We ran:

cp requirements/edx-sandbox/base.txt \
   requirements/edx-sandbox/releases/redwood.txt

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 9, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 9, 2024

Thanks for the pull request, @cmltaWt0! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@cmltaWt0 cmltaWt0 requested a review from kdmccormick May 9, 2024 09:55
@cmltaWt0 cmltaWt0 self-assigned this May 9, 2024
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you also remove the (FUTURE PLAN) from the Redwood part of the edx-sandbox readme?

@cmltaWt0 cmltaWt0 force-pushed the max/feat/pip-sandbox-requirements-redwood branch from a3f4b5b to 5d27e56 Compare May 9, 2024 15:22
@cmltaWt0 cmltaWt0 marked this pull request as ready for review May 9, 2024 15:23
@kdmccormick
Copy link
Member

Ah @cmltaWt0 , before merging, can you rebase and re-copy again? Feanil just merged make upgrade last night after months without an upgrade, so it would be good to get those new pins in the sandbox.

@cmltaWt0 cmltaWt0 force-pushed the max/feat/pip-sandbox-requirements-redwood branch from 5d27e56 to 16d526e Compare May 9, 2024 15:25
@cmltaWt0
Copy link
Contributor Author

cmltaWt0 commented May 9, 2024

Ah @cmltaWt0 , before merging, can you rebase and re-copy again? Feanil just merged make upgrade last night after months without an upgrade, so it would be good to get those new pins in the sandbox.

Done. The previous is push included the latest requirements.

We ran:

    cp requirements/edx-sandbox/base.txt \
       requirements/edx-sandbox/releases/redwood.txt
@cmltaWt0 cmltaWt0 force-pushed the max/feat/pip-sandbox-requirements-redwood branch from 16d526e to 8ff52ce Compare May 9, 2024 15:32
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cmltaWt0 cmltaWt0 merged commit f717de3 into openedx:master May 9, 2024
80 checks passed
@openedx-webhooks
Copy link

@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants