Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include custom relative dates flag info in outline api #34058

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat: include custom relative dates flag info in outline api #34058

merged 1 commit into from
Jan 31, 2024

Conversation

navinkarkera
Copy link
Contributor

Description

Adds custom_relative_dates waffle flag info to course outline rest API. This is required for displaying custom due dates in course outline MFE.

Useful information to include:

  • Which edX user roles will this change impact? Developer.

Supporting information

Private-ref: BB-8485

Testing instructions

  • Get master devstack up and running.
  • Start lms and cms using make {lms,cms}-up.
  • Go to http://localhost:18010/api-docs/
  • Scroll down till you find documentation for /contentstore/v1/course_index/{course_id} api.
  • Use Try it out and check is_custom_relative_dates_active field is included in API.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 15, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@farhaanbukhsh
Copy link
Member

@navinkarkera can I review this as a CC?

@navinkarkera navinkarkera force-pushed the navin/course-outline/update-api branch from 7dc1bd1 to 042bc70 Compare January 29, 2024 14:36
@navinkarkera
Copy link
Contributor Author

@farhaanbukhsh Sure. Thanks!

@navinkarkera navinkarkera force-pushed the navin/course-outline/update-api branch from 042bc70 to 15ee684 Compare January 29, 2024 14:42
@navinkarkera navinkarkera mentioned this pull request Jan 30, 2024
Merged
@KristinAoki KristinAoki merged commit 4590f1e into openedx:master Jan 31, 2024
64 checks passed
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristinAoki KristinAoki KristinAoki approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navinkarkera @openedx-webhooks @farhaanbukhsh @edx-pipeline-bot @KristinAoki