Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed tds width and margins issues #34687

Merged
merged 4 commits into from
May 13, 2024
Merged

fix: fixed tds width and margins issues #34687

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab66687
fix: added fix based on recent master changes
sundasnoreen12 May 7, 2024
f976266
refactor: paragraph tag is not holding children in email template
sundasnoreen12 May 9, 2024
7789923
refactor: added tr tags
sundasnoreen12 May 10, 2024
2c4e039
fix: moved tr outside forloop
sundasnoreen12 May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 20 additions & 28 deletions openedx/core/djangoapps/notifications/templates/notifications/digest_header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,34 +38,26 @@
<tbody>
<tr>
{% for update in email_digest_updates %}
<td width="50%">
<p style="
{% if not forloop.last %}padding-right: 0.5rem{% endif %}
{% if not forloop.first %}padding-left: 0.5rem{% endif %}"
>
<table
width="100%"
cellpadding="0"
cellspacing="0"
style="background: #1b3b40; color: white; border-radius: 8px;
padding: 1.25rem 1rem;"
>
<tbody>
<tr align="center">
<td style="font-weight: 700; font-size: 32px; line-height: 44px; padding: 0">
{{update.count}}
</td>
</tr>
<tr align="center">
<td style="font-weight: 600; font-size: 0.875rem; line-height: 20px; padding: 0">
{{update.title}}
</td>
</tr>
</tbody>
</table>
</p>
</td>
{% endfor %}
<td width="33.33%" style="padding: 0.5rem;">
<table width="100%" cellpadding="0" cellspacing="0" style="background: #1b3b40; color: white; border-radius: 8px; padding: 1.25rem 1rem;">
<tbody>
<tr align="center">
<td style="font-weight: 700; font-size: 32px; line-height: 44px; padding: 0">
{{update.count}}
</td>
</tr>
<tr align="center">
<td style="font-weight: 600; font-size: 0.875rem; line-height: 20px; padding: 0">
{{update.title}}
</td>
</tr>
</tbody>
</table>
</td>
{% if forloop.counter|divisibleby:3 %}
</tr><tr> <!-- Close the row after every third td -->
{% endif %}
{% endfor %}
</tr>
</tbody>
</table>
Expand Down
Loading