Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paver Removal 1/3 #34829

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented May 21, 2024

Description:

  • Removes the Paver commands which we are confident that nobody depends on:
    • pavelib/docs.py:*
    • pavelib/i18n.py:*
    • pavelib/servers.py:*
    • pavelib/quality.py:run_quality
    • pavelib/quality.py:run_pylint
    • pavelib/quality.py:find_fixme
  • Fixes the remaining Paver tests, which haven't been run in CI since we moved tests to GHA back in ~2020.

Part of:

Next PRs:

Testing instructions: None
Merge considerations: None, this is can go out whenever
Other information: I'm intentionally omitting doc updates. We'll do that all at once in Step 3.

@kdmccormick kdmccormick force-pushed the kdmccormick/paver-rm-1 branch from f8f755e to 072f50d Compare May 21, 2024 16:35
@kdmccormick kdmccormick mentioned this pull request May 21, 2024
@kdmccormick kdmccormick reopened this May 21, 2024
This is the first step of Paver removal.
These are the parts that we are confident are unused.

Part of: openedx#34467
They haven't been run in CI in years, and had gradually become broken
We haven't unit-tested or linted these modules ever since testing was
moved from Jenkins to GitHub Actions.
@kdmccormick kdmccormick force-pushed the kdmccormick/paver-rm-1 branch from 072f50d to 1a2d118 Compare May 21, 2024 16:54
This was referenced May 21, 2024
Comment on lines -80 to -81
echo "Finding fixme's and storing report..."
run_paver_quality find_fixme || { EXIT=1; }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step doesn't do anything because there is no pylint report to read the fixme's from. It has been like this ever since pylint was moved into its own github action, ~2021.

@kdmccormick kdmccormick merged commit f820961 into openedx:master May 21, 2024
47 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/paver-rm-1 branch May 21, 2024 19:14
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants