perf: updated onChannelToggle to improve performance

openedx · Jan 24, 2024 · 09c02cb · 09c02cb
1 parent 36f7c93
commit 09c02cb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/notification-preferences/NotificationPreferenceApp.jsx b/src/notification-preferences/NotificationPreferenceApp.jsx
@@ -31,11 +31,11 @@ const NotificationPreferenceApp = ({ appId }) => {
     const { id: notificationChannel } = event.target;
     const isPreferenceNonEditable = (preference) => nonEditable?.[preference.id]?.includes(notificationChannel);
 
-    const activePreferences = appPreferences.filter(
+    const hasActivePreferences = appPreferences.some(
       (preference) => preference[notificationChannel] && !isPreferenceNonEditable(preference),
     );
 
-    dispatch(updateChannelPreferenceToggle(courseId, appId, notificationChannel, activePreferences.length === 0));
+    dispatch(updateChannelPreferenceToggle(courseId, appId, notificationChannel, !hasActivePreferences));
   }, [appId, appPreferences, courseId, dispatch, nonEditable]);
 
   const preferences = useMemo(() => (