-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add toggling for the hardcode support link #863
feat: add toggling for the hardcode support link #863
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
8dcc52c
to
2001880
Compare
Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting.
2001880
to
7ea26d5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #863 +/- ##
===========================================================
Coverage ? 38.74%
===========================================================
Files ? 110
Lines ? 2292
Branches ? 627
===========================================================
Hits ? 888
Misses ? 1319
Partials ? 85 ☔ View full report in Codecov by Sentry. |
@mphilbrick211 this is a backport to the Palm release, can you ask BTR to review if/when the related PR merges to master? |
@openedx/build-test-release-wg-security-patchers - is this something someone could please review/merge? |
Read throughout the code, the PR is completely recreates the original PR to master. Merging. |
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is a backport from master branch
Description:
Added a toggling mechanism for the
unlink all social media accounts
text to display it as a link or text depending on the MFE env setting.The link currently leads to https://support.edx.org/hc/en-us/articles/207206067 which is hardcoded. I suggest adding the variable
SUPPORT_URL_TO_UNLINK_SOCIAL_MEDIA_ACCOUNT
to control whether this text is displayed as a link or as plain text (if this variable is not set to a value). By default, the link leads to the Edx support page. But now it is possible to set some other support URL at the deployment level.Before:
After: