Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toggling for the hardcode support link #863

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Aug 31, 2023

This is a backport from master branch

Description:

Added a toggling mechanism for the unlink all social media accounts text to display it as a link or text depending on the MFE env setting.
The link currently leads to https://support.edx.org/hc/en-us/articles/207206067 which is hardcoded. I suggest adding the variable SUPPORT_URL_TO_UNLINK_SOCIAL_MEDIA_ACCOUNT to control whether this text is displayed as a link or as plain text (if this variable is not set to a value). By default, the link leads to the Edx support page. But now it is possible to set some other support URL at the deployment level.

Before:
screen_75

After:
screen_76

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 31, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 31, 2023
@DmytroAlipov DmytroAlipov force-pushed the feat-unlink-social-media-account-palm branch from 8dcc52c to 2001880 Compare September 1, 2023 10:49
Add a toggling mechanism for the "unlink all social media
accounts" text to show it as a link or text depending on
the MFE env setting.
@DmytroAlipov DmytroAlipov force-pushed the feat-unlink-social-media-account-palm branch from 2001880 to 7ea26d5 Compare September 1, 2023 11:16
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (open-release/palm.master@03e3b67). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master     #863   +/-   ##
===========================================================
  Coverage                            ?   38.74%           
===========================================================
  Files                               ?      110           
  Lines                               ?     2292           
  Branches                            ?      627           
===========================================================
  Hits                                ?      888           
  Misses                              ?     1319           
  Partials                            ?       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 5, 2023
@e0d
Copy link

e0d commented Sep 5, 2023

@mphilbrick211 this is a backport to the Palm release, can you ask BTR to review if/when the related PR merges to master?

@mphilbrick211
Copy link

@openedx/build-test-release-wg-security-patchers - is this something someone could please review/merge?

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 3, 2023
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Oct 24, 2023
@cmltaWt0
Copy link

Read throughout the code, the PR is completely recreates the original PR to master. Merging.

@cmltaWt0 cmltaWt0 merged commit 92fd5fd into openedx:open-release/palm.master Oct 25, 2023
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the feat-unlink-social-media-account-palm branch October 25, 2023 16:17
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants