Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ID attribute to the main content #880

Merged

Conversation

Lunyachek
Copy link
Contributor

Added the missing 'ID' parameter for the main section. When we want to use keyboard navigation through the page, the first anchor we encounter on the account page is 'Skip to main content,' which allows us to skip the header and move to the content area. However, this anchor is linked to the #main ID, which is missing in the main section.

Before fix:

2023-09-19.10.55.34.mov

After:

2023-09-19.10.58.48.mov

@openedx-webhooks
Copy link

openedx-webhooks commented Sep 19, 2023

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 19, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fca6da2) 46.54% compared to head (6c553f9) 46.54%.
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   46.54%   46.54%           
=======================================
  Files         122      122           
  Lines        2548     2548           
  Branches      669      669           
=======================================
  Hits         1186     1186           
  Misses       1286     1286           
  Partials       76       76           
Files Coverage Δ
src/index.jsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2023
@mphilbrick211
Copy link

Hi @openedx/fed-bom! Would someone be able to please review/merge this for us? Thanks!

@mphilbrick211
Copy link

Hi @Mashal-m! Thanks for the review! Are you able to merge this for us as well?

@Mashal-m Mashal-m merged commit c28b8c6 into openedx:master Nov 3, 2023
8 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Lunyachek Lunyachek deleted the lunyachek/fix/add-id-main-content branch March 25, 2024 21:07
@Lunyachek Lunyachek restored the lunyachek/fix/add-id-main-content branch March 25, 2024 21:16
@Lunyachek Lunyachek deleted the lunyachek/fix/add-id-main-content branch March 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants