-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add ID attribute to the main content #880
fix: Add ID attribute to the main content #880
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 46.54% 46.54%
=======================================
Files 122 122
Lines 2548 2548
Branches 669 669
=======================================
Hits 1186 1186
Misses 1286 1286
Partials 76 76
☔ View full report in Codecov by Sentry. |
Hi @openedx/fed-bom! Would someone be able to please review/merge this for us? Thanks! |
Hi @Mashal-m! Thanks for the review! Are you able to merge this for us as well? |
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Added the missing 'ID' parameter for the main section. When we want to use keyboard navigation through the page, the first anchor we encounter on the account page is 'Skip to main content,' which allows us to skip the header and move to the content area. However, this anchor is linked to the #main ID, which is missing in the main section.
Before fix:
2023-09-19.10.55.34.mov
After:
2023-09-19.10.58.48.mov