fix: removed extra loader while updating preferences #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
changed the title
sundasnoreen12
force-pushed
the
sundass/INF-1086
branch
from
3154680 to
bc8197a
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #913 +/- ##
==========================================
+ Coverage 46.44% 46.48% +0.04%
==========================================
Files 116 116
Lines 2405 2407 +2
Branches 640 640
==========================================
+ Hits 1117 1119 +2
Misses 1214 1214
Partials 74 74
☔ View full report in Codecov by Sentry. |
sundasnoreen12
requested review from
awais-ansari,
muhammadadeeltajamul and
abdullahwaheed
Syed-Ali-Abbas-Zaidi
approved these changes
Oct 17, 2023
awais-ansari
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1086
Description
Removed extra loading effect of spinner while updating the notification preferences.
Screenshots
Before
After