Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-8297: fixed incorrect badge and broken associated catalog column #374

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mahamakifdar19
Copy link
Contributor

Jira Ticket: https://2u-internal.atlassian.net/browse/ENT-8297
Description:

  • Fixed incorrect badge. Changed it from 'Business' to 'Subscription'
  • Fixed broken associated catalog column in CSV

UI Screenshots:
Screenshot 2024-02-07 at 2 31 13 PM
Screenshot 2024-02-07 at 2 33 49 PM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7843bc8) 82.29% compared to head (0691d50) 82.29%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #374   +/-   ##
=======================================
  Coverage   82.29%   82.29%           
=======================================
  Files          38       38           
  Lines         706      706           
  Branches      228      228           
=======================================
  Hits          581      581           
  Misses        121      121           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahamakifdar19 mahamakifdar19 merged commit 975df0b into main Feb 9, 2024
6 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-8297 branch February 9, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants