Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add github check to validate i18n string extraction #432

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jajjibhai008
Copy link
Contributor

Description

  1. Fix extract_translations command
  2. Add GitHub check to validate i18n string extraction

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (38c1da6) to head (f64889b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files          43       43           
  Lines         899      899           
  Branches      250      250           
=======================================
  Hits          700      700           
  Misses        191      191           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 changed the title ci: add github check to validate i18n string extraction style: add github check to validate i18n string extraction Jun 20, 2024
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9005 branch from 061569a to f64889b Compare June 21, 2024 07:05
@jajjibhai008 jajjibhai008 merged commit ff2cbcf into main Jun 21, 2024
7 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9005 branch June 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants