Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated lock file version check to use new workflow #200

Closed
wants to merge 2 commits into from

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Aug 25, 2023

Renamed lockfileversion-check-v3 to lockfile-check in lockfile version file.

Ticket

Prototype a way to review NPM lockfiles in PRs

@Mashal-m Mashal-m marked this pull request as draft August 25, 2023 09:45
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8fef92d) 96.45% compared to head (9bbcaad) 96.45%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         195      195           
  Lines        1834     1834           
  Branches      321      321           
=======================================
  Hits         1769     1769           
  Misses         60       60           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m changed the title refactor: update lock file version refactor: updated lock file version check to use new workflow Aug 31, 2023
@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Oct 20, 2023
@justinhynes
Copy link
Contributor

justinhynes commented Nov 8, 2023

Hi @Mashal-m -- this PR is marked as "needs maintainer attention" but the PR is currently a draft (with conflicts).

Is this something that should be ready for review by our team?

@jsnwesson jsnwesson added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 13, 2023
@justinhynes
Copy link
Contributor

Hi @Mashal-m. I haven't heard anything back from November. I am going to be closing this PR.

Please re-open if needed.

@justinhynes justinhynes closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer. waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants