-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get brand logo file path from env (#205) #252
fix: get brand logo file path from env (#205) #252
Conversation
Co-authored-by: Brian Smith <[email protected]>
Thanks for the pull request, @shahbaz-shabbir05! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #252 +/- ##
=============================================================
Coverage ? 96.46%
=============================================================
Files ? 195
Lines ? 1839
Branches ? 322
=============================================================
Hits ? 1774
Misses ? 60
Partials ? 5 ☔ View full report in Codecov by Sentry. |
@arbrandes or @mariajgrimaldi Hi, This is the backport of #205 to fix the hardcoded brand logo URL in this Quince release. Could any of you review or comment? |
@shahbaz-shabbir05, FYI, I'm aiming to pull in everything that's on master into Quince via #243. |
@arbrandes Thank you for the update. I was wondering if there's a specific timeline for when the Also, you're planning to add everything from the |
I believe this should be handled by backporting #232 so we can use runtime config instead. |
@brian-smith-tcril Appreciate the update. I'll proceed to close this PR now. |
@shahbaz-shabbir05 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR makes changes so that the
LOGO_URL
can be used from the config in theQuince
branch. These changes have already been made and merged in themaster
branch.The PR for the master branch is linked here: #205 & #238
Additional context: #178