Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display support and programs in nav only if they are configured #507

Merged

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Nov 19, 2024

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 19, 2024

Thanks for the pull request, @dcoa!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (08d47dd) to head (c6891ef).
Report is 2 commits behind head on open-release/sumac.master.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           open-release/sumac.master     #507   +/-   ##
==========================================================
  Coverage                      97.40%   97.40%           
==========================================================
  Files                            157      157           
  Lines                           1385     1389    +4     
  Branches                         228      231    +3     
==========================================================
+ Hits                            1349     1353    +4     
  Misses                            34       34           
  Partials                           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). backport PR backports a change from main to a named release. labels Nov 21, 2024
@dcoa dcoa marked this pull request as ready for review November 25, 2024 09:47
@dcoa dcoa requested a review from a team as a code owner November 25, 2024 09:47
@dcoa dcoa requested a review from arbrandes November 25, 2024 09:50
@jsnwesson
Copy link
Contributor

I'll hold off on merging this (if indeed the wait is on Aperture) so that anyone from AXIM can review and approve this backport.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 28, 2024
@itsjeyd
Copy link

itsjeyd commented Nov 28, 2024

I'll hold off on merging this (if indeed the wait is on Aperture) so that anyone from AXIM can review and approve this backport.

CC @openedx/axim-engineering ⬆️

Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on Tutor devstack for Sumac
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ✅ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@deborahgu
Copy link
Member

I'll go ahead and merge. In the future, @dcoa, could you make individual backport PRs for each master PR, just to make reviewing easier? Thanks!

@deborahgu deborahgu merged commit 261448d into openedx:open-release/sumac.master Dec 2, 2024
7 checks passed
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants