-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added main id to main block #512
Conversation
Thanks for the pull request, @Ankush1oo8! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and tested this, and it looks good so far. I provided a recording to show that keyboard and screenreader navigation are closer to working as they should (edit: I tried adding a screenrecording, but GitHub wasn't down to upload it), but this fix exposed another bug where for some reason the first announcement is about the passing grade for the bottom-most course. If you want to try to fix that in this PR, it'd be great, otherwise I think you can open another issue ticket to address it for future work.
Aside from that, I'll wait to approve this until some of the other failing tasks are addressed:
- you'll need to fix the lint errors that are noted by the linter
- ensure the CLA is signed and approved
- and I'm going to predict that a failing test will eventually be that the Jest Snapshot isn't going to pass with this new change. To update the Jest Snapshot, you can run
npm run snapshot
in your terminal and push theApp.test.jsx.snap
file to your PR.
Let me know if you have any questions!
What is the lint error in the code |
@Ankush1oo8 you can find the lint errors by running |
And although it's not an actual blocker, if you can fix your commit message by following the OEP-51 document, that'll pass your first test. |
Okey 😁 |
sir can you what is wrong in the new commit |
@Ankush1oo8 Ah! All that was missing is the
You had done it correctly before, but I think that you're still going to need to fill out the Contributor Agreement (CLA) if you haven't already. I'm not responsible for the CLA process, so I'm not sure if you already filled it out and are just waiting to be approved. |
I have filled it but did not receive any info about verification |
Ah! Then it could be that the person verifying it still needs to take a look at it 😄 One thing you can do while you wait is also make sure to update this branch with any new changes that occur from other Pull Requests. You can do that by clicking on the |
I have updated the branch |
@Ankush1oo8 I'm also looking into why the Node CI test is failing for an email notification, which I don't think has to do with your work. I've seen this in other PRs for this repo. In the mean time, I think now you just need to wait on getting your CLA verified before this PR can be merged. |
@Ankush1oo8 It looks like commitlint is still reporting some issues. Could you please fix those? This comment should have the info that you'll need. |
Can you check now I have made the change |
@Ankush1oo8 the commitlint will check all of your commits, so although some use the correct syntax (ie. |
So can I edit the commit messages |
Fixed the issue #510 and did not make any changes in format as per the instructions