Tran

[ReaksmeyThan]

No description provided.

[openedx-webhooks]

Thanks for the pull request, @ReaksmeyThan!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[deborahgu]

hi, @ReaksmeyThan. This is a huge change with no description that includes at least one banner image including misspelled words, and what appears to be a large number of spam links. Could you explain what you are attempting to do here? Is this an error or are you attempting to push spam links into this open source code base? I'm going to assume that this was a mistake, in which case, could you explain your intent?

[ReaksmeyThan]

Hi @deborahgu,

I sincerely apologize for the confusion caused by this pull request. I mistakenly submitted it while I was intending to fork the repository and work on my own branch for personal purposes. This was not intentional, and I truly appreciate your understanding.

Thank you for pointing this out, and I will be more careful in the future.
sorry this my mistake to pull request accidentally.

[ReaksmeyThan]

Hi @deborahgu, I sincerely apologize for the confusion caused by this pull request. I accidentally submitted it while I was intending to fork the repository and work on my own branch for personal purposes. This was not intentional, and I truly appreciate your understanding. Thank you for pointing this out, and I will be more careful in the future.

…

On Mon, Dec 2, 2024 at 8:24 PM Deborah Kaplan ***@***.***> wrote: ***@***.**** requested changes on this pull request. hi, @ReaksmeyThan <https://github.com/ReaksmeyThan>. This is a huge change with no description that includes at least one banner image including misspelled words, and what appears to be a large number of spam links. Could you explain what you are attempting to do here? Is this an error or are you attempting to push spam links into this open source code base? I'm going to assume that this was a mistake, in which case, could you explain your intent? — Reply to this email directly, view it on GitHub <#516 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJPJT6Z3HAA45FQPEPBC4XL2DRNRHAVCNFSM6AAAAABSYWFN3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZSGY4TINZSGQ> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[deborahgu]

I'm so glad that's all it was! After I wrote the comment I thought about it and I realize it was probably an accidental PR to the wrong fork. We do appreciate open source contributions so if you ever do have something to submit back to master just let us know!

[ReaksmeyThan]

Hi @deborahgu,

Thank you so much for understanding! I really appreciate your kind response and your encouragement for open-source contributions. I'll definitely keep that in mind and make sure to be more careful next time. If I ever have something valuable to contribute, I'll be sure to submit it properly.

Thanks again for your patience and support!