Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URLs get the current value of LMS_BASE_URL from getConfig() #284

Merged

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Feb 7, 2024

Description

This PR is a backport for #273 so unenrollments work in the learner dashboard.

Resolves openedx/wg-build-test-release#336

@openedx-webhooks
Copy link

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (141d490) 96.36% compared to head (c41ce5d) 96.36%.
Report is 1 commits behind head on open-release/quince.master.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           open-release/quince.master     #284   +/-   ##
===========================================================
  Coverage                       96.36%   96.36%           
===========================================================
  Files                             194      194           
  Lines                            1843     1843           
  Branches                          326      326           
===========================================================
  Hits                             1776     1776           
  Misses                             62       62           
  Partials                            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Feb 8, 2024
@itsjeyd
Copy link

itsjeyd commented Feb 8, 2024

Hey @jsnwesson, this is the backport for #273 which you merged yesterday. Mind giving it a quick look, too? :)

CC @arbrandes

@cmltaWt0
Copy link

cmltaWt0 commented Feb 8, 2024

Tested via a Tutor local deployment. Unenroll feature works great!
Also a Programs URL is formed correctly.

@cmltaWt0
Copy link

cmltaWt0 commented Feb 9, 2024

@itsjeyd I'm going to merge it since the upstream PR literally identical and we have to make a release today.

CC @arbrandes

@cmltaWt0 cmltaWt0 merged commit 73ed886 into openedx:open-release/quince.master Feb 9, 2024
6 checks passed
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@jsnwesson jsnwesson removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants