-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: URLs get the current value of LMS_BASE_URL from getConfig() #284
fix: URLs get the current value of LMS_BASE_URL from getConfig() #284
Conversation
Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
9434f1c
to
c41ce5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #284 +/- ##
===========================================================
Coverage 96.36% 96.36%
===========================================================
Files 194 194
Lines 1843 1843
Branches 326 326
===========================================================
Hits 1776 1776
Misses 62 62
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Hey @jsnwesson, this is the backport for #273 which you merged yesterday. Mind giving it a quick look, too? :) CC @arbrandes |
Tested via a Tutor local deployment. Unenroll feature works great! |
@itsjeyd I'm going to merge it since the upstream PR literally identical and we have to make a release today. CC @arbrandes |
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR is a backport for #273 so unenrollments work in the learner dashboard.
Resolves openedx/wg-build-test-release#336