feat: updated the custom expiration model design and truly blocking

[jajjibhai008]

Description

• Updated the custom expiration model design
• Make that modal truly blocking

JIRA -> ENT-9616, ENT-9618

For all changes

• Ensure adequate tests are in place (or reviewed existing tests cover changes)
• Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

• Ensure to attach screenshots
• Ensure to have UX team confirm screenshots

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (6aaebbb) to head (2485230).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1209   +/-   ##
=======================================
  Coverage   88.42%   88.43%           
=======================================
  Files         399      399           
  Lines        8502     8508    +6     
  Branches     2089     2096    +7     
=======================================
+ Hits         7518     7524    +6     
  Misses        941      941           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mahamakifdar19]

LGTM

[adamstankiewicz]

[curious] I wonder if this sort of validation around url formatting should live in the backend so when consuming the urls in the frontend, we could assume the URL is properly formatted with a protocol. This would simplify this frontend implementation and its associated tests by keeping less business logic in the frontend.

For example, when configuring the URL in Django Admin, if it's missing a protocol, could alternatively consider:

• Raising a ValidationError in the clean method to prevent saving, and informing the user a protocol is required.
• Do the above transform when saving the record, so it saves in the DB properly formatted.

Definitely an edge case but as is, if the configured URL is missing the protocol and does not support https, I believe this implementation would result in the link not working properly as it assumes https (which is a valid assumption).

[adamstankiewicz]

Did we want to use DomPurify.sanitize here (see a couple other places in this repo it's used). Ideally, we should be using it anytime using dangerouslySetInnerHTML to as a security measure to prevent unsafe HTML (e.g., script injection, XSS attacks, etc.).

I know we use dangerouslySetInnerHTML in a few other places without DomPurify.sanitize but it would be awesome if we can ensure DomPurify.sanitize was added in these other spots, too 😄