Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styles on expiry modal #1212

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: styles on expiry modal #1212

merged 1 commit into from
Oct 21, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Oct 21, 2024

Description

Issue:

  • Modal title text was showing some unnecessary spaces

Fix:

  • Override base class to fix the issue
Screenshot 2024-10-21 at 4 36 18 PM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (6aaebbb) to head (126952a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   88.42%   88.43%           
=======================================
  Files         399      399           
  Lines        8502     8508    +6     
  Branches     2089     2053   -36     
=======================================
+ Hits         7518     7524    +6     
- Misses        941      942    +1     
+ Partials       43       42    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 merged commit 8b39c33 into master Oct 21, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9616 branch October 21, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants