chore: Gate expiration subs modal by license state as well as feature toggle #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
approved these changes
Oct 30, 2024
Comment on lines
+10
to
+11
| const displaySubscriptionExpirationModal = customerAgreement?.hasCustomLicenseExpirationMessaging | ||
| && !subscriptionLicense?.subscriptionPlan.isCurrent; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1216 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 399 399
Lines 8502 8504 +2
Branches 2051 2090 +39
=======================================
+ Hits 7518 7520 +2
Misses 942 942
Partials 42 42 ☔ View full report in Codecov by Sentry. |
brobro10000
approved these changes
Oct 30, 2024
adamstankiewicz
approved these changes
Oct 30, 2024
| customerAgreement: { | ||
| hasCustomLicenseExpirationMessaging: true, | ||
| modalHeaderText: 'Expired Subscription', | ||
| buttonLabelInModal: 'Continue Learning', |
There was a problem hiding this comment.
nit: Continue learning as our button case is sentence case.
macdiesel
added a commit
that referenced
this pull request
Oct 30, 2024
macdiesel
added a commit
that referenced
this pull request
Oct 30, 2024
macdiesel
added a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.