Prevent SubscriptionExpirationModal from displaying when custom messages enabled. #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdiesel
commented
Oct 30, 2024
src/components/expired-subscription-modal/tests/ExpiredSubscriptionModal.test.jsx
Outdated
Show resolved
Hide resolved
adamstankiewicz
approved these changes
Oct 30, 2024
macdiesel
force-pushed
the
bbeggs/expiration_modal_fix
branch
from
80ed600
to
df7b42e
Compare
macdiesel
force-pushed
the
bbeggs/expiration_modal_fix
branch
from
df7b42e
to
a0b504f
Compare
adamstankiewicz
approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1217 +/- ##
=========================================
Coverage ? 88.43%
=========================================
Files ? 399
Lines ? 8505
Branches ? 2054
=========================================
Hits ? 7521
Misses ? 942
Partials ? 42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents original/standard subscriptions expiration modal from renders simultaneously with the custom subs messaging modal.