Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vsf expired messaging issue #1218

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Oct 31, 2024

Description

Backend PR: openedx/license-manager#734 (review)

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@0c14daf). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1218   +/-   ##
=========================================
  Coverage          ?   88.43%           
=========================================
  Files             ?      399           
  Lines             ?     8505           
  Branches          ?     2054           
=========================================
  Hits              ?     7521           
  Misses            ?      942           
  Partials          ?       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 merged commit 66a5d34 into master Oct 31, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/vsf-changes branch October 31, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants