From 8ee2356a7f8487617133ed60719ebf94e9fe87a7 Mon Sep 17 00:00:00 2001 From: Brian Smith Date: Mon, 30 Sep 2024 09:55:11 -0400 Subject: [PATCH] Revert "test: Remove support for Node 18 (#397)" This reverts commit 6d70b87d410193c6e7b0be64e757a7eaed0bb53e. Node 18 removal PRs should be merged after Sumac is cut. --- .github/workflows/ci.yml | 5 ++++- .github/workflows/lockfileversion-check.yml | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 930b237c..3a1650ee 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,6 +3,9 @@ on: [push, pull_request] jobs: tests: runs-on: ubuntu-latest + strategy: + matrix: + node: [18, 20] steps: - name: Checkout uses: actions/checkout@v4 @@ -11,7 +14,7 @@ jobs: - name: Setup Nodejs uses: actions/setup-node@v4 with: - node-version-file: '.nvmrc' + node-version: ${{ matrix.node }} - name: Install dependencies run: npm ci - name: Validate package-lock.json changes diff --git a/.github/workflows/lockfileversion-check.yml b/.github/workflows/lockfileversion-check.yml index 916dcb40..6ac66558 100644 --- a/.github/workflows/lockfileversion-check.yml +++ b/.github/workflows/lockfileversion-check.yml @@ -10,4 +10,4 @@ on: jobs: version-check: - uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master + uses: openedx/.github/.github/workflows/lockfile-check-v20.yml@master