Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update import path of frontend-plugin-framework #311

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

jsnwesson
Copy link
Contributor

This PR bumps the version of Frontend Plugin Framework library in order to use the built package of FPF. This will effectively reduce the package size of the dependency by 0.5 MB.

  • reference the dependency's build instead of /src

* reference the dependency's build instead of /src
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.73%. Comparing base (07ae0bb) to head (2d7334a).

❗ Current head 2d7334a differs from pull request most recent head 617794e. Consider uploading reports for the commit 617794e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files          28       28           
  Lines         410      410           
  Branches       87       87           
=======================================
  Hits          290      290           
  Misses        119      119           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinhynes
Copy link
Contributor

@jsnwesson -- Approved, pending conflict resolution.

@jsnwesson jsnwesson merged commit 883b9c6 into master Mar 29, 2024
6 checks passed
@jsnwesson jsnwesson deleted the jwesson/update-fpf branch March 29, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants