Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #1128

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Jun 9, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Jun 9, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft June 9, 2023 08:21
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/react-router-upgrade branch from 5f6f341 to 781c96b Compare June 9, 2023 10:05
@arbrandes
Copy link

@Syed-Ali-Abbas-Zaidi, I'd love to help push this forward. Do you mind resolving conflicts? Also, is there a particular reason the PR is still a draft?

Thanks!

@arbrandes arbrandes self-requested a review September 5, 2023 12:20
@Syed-Ali-Abbas-Zaidi
Copy link
Contributor Author

This PR is currently blocked due to React v17 upgrade that is the reason I have marked it as Draft.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (b7a3d56) 87.87% compared to head (233fda5) 88.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   87.87%   88.09%   +0.22%     
==========================================
  Files         263      266       +3     
  Lines        4485     4518      +33     
  Branches     1133     1142       +9     
==========================================
+ Hits         3941     3980      +39     
+ Misses        530      524       -6     
  Partials       14       14              
Files Coverage Δ
src/constants.js 100.00% <100.00%> (ø)
src/course-home/outline-tab/OutlineTab.jsx 95.74% <100.00%> (+0.09%) ⬆️
src/courseware/CoursewareRedirectLandingPage.jsx 100.00% <100.00%> (+33.33%) ⬆️
src/courseware/RedirectPage.jsx 100.00% <100.00%> (ø)
src/courseware/course/CourseBreadcrumbs.jsx 100.00% <ø> (ø)
src/courseware/course/JumpNavMenuItem.jsx 95.45% <100.00%> (+0.21%) ⬆️
src/courseware/course/course-exit/CourseExit.jsx 94.73% <100.00%> (ø)
...eware/course/sequence/content-lock/ContentLock.jsx 100.00% <100.00%> (ø)
...ourseware/course/sequence/honor-code/HonorCode.jsx 100.00% <100.00%> (ø)
src/courseware/utils.jsx 100.00% <100.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/react-router-upgrade branch 2 times, most recently from 9895782 to 62dd7d8 Compare September 13, 2023 10:35
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/react-router-upgrade branch from 62dd7d8 to 86cb5a2 Compare September 13, 2023 11:38
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review September 13, 2023 11:59
@arbrandes
Copy link

Looks like React v17 was merged, congrats! Can we move this one forward, now?

@Syed-Ali-Abbas-Zaidi
Copy link
Contributor Author

Looks like React v17 was merged, congrats! Can we move this one forward, now?

Yes, I have already notified the owning squad (aurora) they are currently working on testing these changes locally. Once testing is done this PR will be good to go.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mattcarter mattcarter merged commit b788b96 into master Oct 4, 2023
5 checks passed
@mattcarter mattcarter deleted the Ali-Abbas/react-router-upgrade branch October 4, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants