-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade react router to v6 #1128
Conversation
5f6f341
to
781c96b
Compare
@Syed-Ali-Abbas-Zaidi, I'd love to help push this forward. Do you mind resolving conflicts? Also, is there a particular reason the PR is still a draft? Thanks! |
This PR is currently blocked due to React v17 upgrade that is the reason I have marked it as Draft. |
…o Ali-Abbas/react-router-upgrade
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
+ Coverage 87.87% 88.09% +0.22%
==========================================
Files 263 266 +3
Lines 4485 4518 +33
Branches 1133 1142 +9
==========================================
+ Hits 3941 3980 +39
+ Misses 530 524 -6
Partials 14 14
☔ View full report in Codecov by Sentry. |
9895782
to
62dd7d8
Compare
62dd7d8
to
86cb5a2
Compare
Looks like React v17 was merged, congrats! Can we move this one forward, now? |
Yes, I have already notified the owning squad (aurora) they are currently working on testing these changes locally. Once testing is done this PR will be good to go. |
…o Ali-Abbas/react-router-upgrade
…o Ali-Abbas/react-router-upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Ticket
React Router Upgrade to v6.
Description
This PR upgrades React Router from
v5
tov6
.