Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untranslatable strings #1193

Closed
ghassanmas opened this issue Sep 21, 2023 · 2 comments · Fixed by #1505
Closed

Untranslatable strings #1193

ghassanmas opened this issue Sep 21, 2023 · 2 comments · Fixed by #1505
Labels
bug Report of or fix for something that isn't working as intended

Comments

@ghassanmas
Copy link
Member

ghassanmas commented Sep 21, 2023 •
edited
Loading

The Following is a list of strings that are hardcoded, untranslatable

  1. View course in

    frontend-app-learning/src/instructor-toolbar/InstructorToolbar.jsx

    Line 78 in 168ed1e

    <span className="mr-2 mt-1 col-form-label">View course in:</span>
  2. Specific Student...

    frontend-app-learning/src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx

    Line 99 in 168ed1e

    masquerade: 'Specific Student...',
  3. View this course as:

    frontend-app-learning/src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx

    Line 123 in 168ed1e

    <span className="col-auto col-form-label pl-3">View this course as:</span>
@jciasenza
Copy link
Contributor

I can take this issue @arbrandes

@jciasenza
Copy link
Contributor

@arbrandes
Add message ids and add a file
src/instructor-toolbar/messages.js
image

Also modify the masquerade
src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx
image

If you approve my changes I will push them,
or if something needs to be modified let me know thanks !!!
Atte
Juan Carlos (Aulasneo)

This was referenced Aug 12, 2024
Closed
Open
jciasenza added a commit to jciasenza/frontend-app-learning that referenced this issue Aug 27, 2024
@jciasenza
Fix Untranslatable strings openedx#1193
04d3aa7
@jciasenza jciasenza mentioned this issue Aug 27, 2024
Closed
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 7, 2024
@itsjeyd itsjeyd removed this from Contributions Sep 7, 2024
@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Sep 12, 2024
@jciasenza jciasenza mentioned this issue Oct 26, 2024
Merged
bradenmacdonald pushed a commit that referenced this issue Oct 29, 2024
@jciasenza
fix: untranslatable strings in Instructor Toolbar #1193 (#1505)
2d1f893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Milestone
No milestone
3 participants
@bradenmacdonald @ghassanmas @jciasenza